Reviewers can use this list for some common things to watch for when doing new driver reviews. This list is by no means exhaustive, but does try to capture some of things that have been found in past reviews.
Note
Feel free to propose additional items to help make this a more complete list.
cinder.conf
and not in separate
vendor specific config file.connector == None
for force detachtox -e pep8
), but start here first:
https://docs.openstack.org/hacking/latest/user/hacking.htmltox -e fast8
can be used as a quick check only against modified filestox -e compliance
to make sure all required interfaces are
implemented.@interface.volumedriver
VERSION
constant defined in driver classCI_WIKI_NAME
constant defined in driver classVolumeDriverException
or
VolumeBackendAPIException
cinder.conf
and all cinder service logs availablelocal.conf/cinder.conf
cinder.conf
and enableddefault_volume_type
and enabled_backends
in cinder.conf
, ORCINDER_DEFAULT_VOLUME_TYPE
and CINDER_ENABLED_BACKENDS
in
local.conf
, ORTEMPEST_VOLUME_DRIVER
and TEMPEST_VOLUME_VENDER
in
local.conf
CINDER_BRANCH
in local.conf
, ORgit fetch https://review.opendev.org/openstack/cinder refs/changes/56/657856/2 && git checkout cherry-pick
(https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers )tox -e all -- *volume*
tox
| tempest
with --subunit
helps generate HTML output
(https://docs.openstack.org/os-testr/latest/user/subunit2html.html )tox
| tempest
with --concurrency=<n>
for specifying <n>
number of test runnersreleasenotes/notes/
in the repository root directory. It should
not be located in the driver’s section of the code tree.doc/source/reference/support-matrix.ini
and
doc/source/reference/support-matrix.rst
doc/source/configuration/block-storage/drivers
cinder/opts.py
including the new driver library options using
the command tox -e genopts
Except where otherwise noted, this document is licensed under Creative Commons Attribution 3.0 License. See all OpenStack Legal Documents.